[enhancement](cloud) add bvar to monitor s3 throughput&QPS#34087
[enhancement](cloud) add bvar to monitor s3 throughput&QPS#34087dataroaring merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
| bvar::Adder<uint64_t> s3_file_reader_total("s3_file_reader", "total_num"); | ||
| bvar::Adder<uint64_t> s3_bytes_read_total("s3_file_reader", "bytes_read"); | ||
| bvar::Adder<uint64_t> s3_file_being_read("s3_file_reader", "file_being_read"); | ||
| bvar::LatencyRecorder s3_bytes_per_read("s3_file_reader", "bytes_per_read"); // also QPS |
There was a problem hiding this comment.
It seems calculating the rate of s3_bytes_read_total (throughput) and s3_file_reader_read_counter (qps), by grafana, will do the work.
Adding redundant metrics is a burden for the scraping procedure (Prometheus).
There was a problem hiding this comment.
bvar has fine granularity, so it is easier to identify throughput issue (whether caused by long wait or low instantaneous speed). So I insist, but we can delete them when the optimization work is done.
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run cloudp1 |
|
run cloud_p1 |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
5 participants
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...